Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: RFC Mutually Exclusive Pods Uniformly Distributed Scheduling #1623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: RFC Mutually Exclusive Pods Uniformly Distributed Scheduling #1623

wants to merge 1 commit into from

Conversation

helen-frank
Copy link
Contributor

@helen-frank helen-frank commented Sep 1, 2024 •
edited
Loading

Fixes #1418

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: helen-frank
Once this PR has been reviewed and has the lgtm label, please assign ellistarn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2024
@helen-frank
Copy link
Contributor Author

Request for review of RFC
/cc @ellistarn @jwcesign

@k8s-ci-robot
Copy link
Contributor

@helen-frank: GitHub didn't allow me to request PR reviews from the following users: jwcesign.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Request for review of RFC
/cc @ellistarn @jwcesign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@helen-frank
Copy link
Contributor Author

/retest

@helen-frank helen-frank mentioned this pull request Sep 10, 2024
Closed
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@helen-frank
Copy link
Contributor Author

ping @ellistarn

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2024
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11482474851

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 80.873%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
Totals Coverage Status
Change from base Build 11450026141: 0.05%
Covered Lines: 8486
Relevant Lines: 10493
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024
@helen-frank
Copy link
Contributor Author

/cc @njtran @ellistarn

Please take a look

jwcesign
jwcesign reviewed Oct 23, 2024
View reviewed changes
designs/mutually-exclusive-pods-uniformly-distributed-scheduling.md
## Recommended Solution

By sorting in byCPUAndMemoryDescending, pods with the same specifications (cpu or memory request equal) and mutually exclusive pods (with PodAntiAffinity or TopologySpreadConstraints) are prioritized to be scheduled first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the theory details here?

designs/mutually-exclusive-pods-uniformly-distributed-scheduling.md Outdated Show resolved Hide resolved
designs/mutually-exclusive-pods-uniformly-distributed-scheduling.md
Code implementation: [pull 1548](https://github.com/kubernetes-sigs/karpenter/pull/1548)

### Test Results

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will be the impact if a user upgrades to a version that includes this feature?

Will the existing nodes need to be recreated according to the new logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new scheduling results are more balanced, and that's about it. No changes are needed for that.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwcesign jwcesign jwcesign left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jmdeal jmdeal Awaiting requested review from jmdeal

@ellistarn ellistarn Awaiting requested review from ellistarn

@njtran njtran Awaiting requested review from njtran

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node selection: One supper large node with many small size nodes
4 participants
@helen-frank @k8s-ci-robot @coveralls @jwcesign